#1
|
||||
|
||||
Edit History text diff problems
http://vgmdb.net/artist/2746
Compare the current text of the biography with the diff it shows for me. There are several words I removed that it doesn't show as having been removed.
__________________
hi~ |
#2
|
||||
|
||||
That's why I haven't really publicly promoted the diff viewer. It's just a piece of open-source code I downloaded that provides inline diff capability in php, but it has a lot of quirks, and really fails when presented with a paragraph of text.
I'm open to other options, if you know of a tool that can handle both inline and line-by-line comparisons. |
#3
|
|||
|
|||
I wonder if the current source code even can't provide the line index or offset of where the algorithm thinks the diff exits. If it can, then there is something lacking in our presentation, and if can't, then the algorithm itself has an issue.
Could anybody figure out what Winged Cat and strugglepoo ever did in the respective albums? It's almost kinda playing Where's Wally? in super hell mode... |
#4
|
||||
|
||||
An edit like that is usually a change in the whitespace, maybe a trailing space or double-space somewhere.
|
#5
|
|||
|
|||
The Theatrhythm one was actually easier than thought. The track header of the disc 3 was wrong and thus corrected!
Quote:
Quote:
I think the typical line-to-line comparison view, instead of strike through, would be better if we can change the diff presentation. |
#6
|
||||
|
||||
Heh, I actually noticed that myself and was worried it would be difficult to figure out, or if you had some other staff tool(s) for that process. In the future I will make a post in the thread when it comes to small corrections not showing up.
|
#7
|
|||
|
|||
Actually, I've not actually paid much attention to our diff function while knowing it was far from perfect, but nowadays I feel it really hurts not to have a proper edit history viewer for a user submission-based website like us. There is another comparison viewer for admins/staffs, and although it shows both the original and edited texts, it doesn't give any highlight to tell where the difference is and thus it's still lacking. In the longer term, we'll hugely benefit from a little coding work to have a better diff.
I think our diff isn't that bad. It's very quick and comprehensive, in comparison to Wikipedia's crappy one. It claimed "Nobuo Uematsu" and "Uematsu Nobuo" are the same (and for that matter "Nobuo Uematsu Uematsu Uematsu Nobuo" is the same as well), but perhaps it just takes a heuristic approach for the presentation. So, on the condition that the current algorithm gets the shortest edit script, we only have a problem with the presentation that can be vastly improved by two or three steps.
I created a mock viewer from scratch including an O(NP) algorithm to see if I was asking too much at all, and I find that 1) and 2) are pretty easy and requires only a little work (but of course, depended on the current implementation). 3) may require some efforts. 4), while I don't try yet, doesn't look hard. If VGMdb provides. a GET API for edit histories, somebody can host an external service, but nothing beats an official implementation, so I'd just hope it would be pushed onto a task list by any chance. |
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Login problems | Rrolack | Questions and Comments | 2 | Jun 21, 2015 09:26 AM |
How to edit/change thread title? | Porter | Questions and Comments | 1 | Aug 4, 2014 07:16 AM |
Add/edit notes in the db | Radical Pan | Questions and Comments | 3 | Sep 21, 2009 10:00 AM |